You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Closing as superseded — three of the four changes here have landed by other routes, and the branch conflicts with main.
this PR proposes
on main today
@TOOL_VERSION@ 0.5.0 → 0.5.1, suffix → 0
0.5.2, suffix 0 — ahead of this PR
attribute reordering (size, multiple, area, collection_type moved last)
already exactly that form
<environment_variable> re-indent
already done
expect_test_failure="true" → "false" on two tests
⛔ still "true"
The reordering and indentation are presumably the canonical-form check enforcing them since; the version has been bumped twice past this branch.
The one thing that never landed is the expect_test_failure flip, and it deserves its own PR rather than riding along with cleanup.expect_test_failure="true" asserts this test is expected to fail; the egapx tools run the quay.io/galaxy/egapx container and pull SRA data, which CI cannot do. Flipping it to false is a claim about the environment, not a tidy-up, and it would turn those tests red in Test tools if the claim is wrong.
⚠ Worth noting if it is revisited: main now has four of these, not the two this PR touched —
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FOR CONTRIBUTOR: